-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read from META.json and more #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use list of provided packages from META.json or META.yml
... and pass result as JSON to cpanspec. Scripts like Makefile.PL or Build.PL should not be loaded from inside a script.
First look into the meta files for prereqs and provides. If not found or 'dynamic_config' is set, only then execute Makefile.PL/Build.PL etc.
Fix checking for dynamic_config
Example statistics output:
So the logs can easily be analyzed with this:
|
Martchus
reviewed
Apr 29, 2021
It wasn't actually used anymore, and it is unreliable. We only rely on META.(json|yaml) and Makefle.PL etc. now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
cpanspec
META.json
(dependencies,dynamic_config
,provides
)provides
exists inMETA.(json|yaml)
Makefile.PL
etc. ifdynamic_config
exists inMETA.(json|yaml)
and is falseMakefile.PL
etc. into it's own subprocessto avoid influencing the result@INC
and aBuild.PL
of a module was callingrequire "Makefile.PL"
effectively callingcpanspec/Makefile.pL
Issue: https://progress.opensuse.org/issues/90047, #21